Shutdown health check registry #1084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an ability to gracefully shutdown the executor for async tasks in `HealthCheckRegistry`. Now it creates a ScheduledExecutorService which should be correctly closed when `HealthCheckRegistry` is not used anymore.
Some CI environments return the amount of available processors as 128. It's rather expensive to create such big thread pools by default. Let's start with 2 threads and the user wants to increase the amount, she can do that.
So they don't prevent the JVM from shutdown if the user didn't shut down the executor gracefully.
|
LGTM |
|
Bummer, I screwed up and this change was not added to 3.2.0. I will mark it for 3.2.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow-up for #1077
Add a method for graceful shutdown of HealthCheckRegistry
Add an ability to gracefully shutdown the executor for async tasks in
HealthCheckRegistry.Now it creates a ScheduledExecutorService which should be correctly closed when
HealthCheckRegistryis not used anymore.Make the pool size more pessimistic by default
Some CI environments return the amount of available processors as 128.
It's rather expensive to create such big thread pools by default. Let's start
with 2 threads and the user wants to increase the amount, she can do that.
Make the async health check threads as daemons
So they don't prevent the JVM from shutdown if the user didn't shut down
the executor gracefully.