Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default value for token added #32

Merged
merged 7 commits into from
Jan 28, 2022
Merged

Default value for token added #32

merged 7 commits into from
Jan 28, 2022

Conversation

pseusys
Copy link
Contributor

@pseusys pseusys commented Jan 28, 2022

Closes #31 issue

@dsaltares
Copy link
Owner

dsaltares commented Jan 28, 2022

First, thanks for the PR!

Are you sure this works?
Most actions that require the Github token force you to make it explicit. For example: https://github.com/marketplace/actions/godot-export#environment-variables.
IIRC I tested to default it and it didn't work.

@pseusys
Copy link
Contributor Author

pseusys commented Jan 28, 2022

@dsaltares
Copy link
Owner

dsaltares commented Jan 28, 2022

Could you please make sure the action works with the implicit token? Once you test it, I'd be happy to get it merged!

@pseusys
Copy link
Contributor Author

pseusys commented Jan 28, 2022

I've tried to run your test file without specifying token explicitly, here are the results: https://github.com/pseusys/fetch-gh-release-asset/actions/workflows/demo.yml

@dsaltares
Copy link
Owner

Thanks!

@dsaltares dsaltares merged commit d608855 into dsaltares:master Jan 28, 2022
BSteffaniak pushed a commit to FlatLang/fetch-airship that referenced this pull request Oct 12, 2022
Default value for token added
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add default value for token argument
2 participants