Skip to content

docs (Microsoft Auth): Add docs regarding whitelist system #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 26, 2023
Merged

docs (Microsoft Auth): Add docs regarding whitelist system #300

Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b5d11b3
docs (Microsoft Auth): Add docs regarding whitelist system
GeekCornerGH Jul 26, 2023
98ad695
docs: Commit Dan's suggestion
GeekCornerGH Jul 26, 2023
e593756
docs: Commit Dan's second suggestion
GeekCornerGH Jul 26, 2023
dea365e
docs: Commit Dan's third suggestion
GeekCornerGH Jul 26, 2023
a34bd54
docs: Commit Dan's fourth suggestion
GeekCornerGH Jul 26, 2023
c064901
docs: Commit Dan's fifth suggestion
GeekCornerGH Jul 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 20 additions & 3 deletions docs/MicrosoftAuth.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,18 +18,35 @@ Authenticating with Microsoft is fully supported by Helios Launcher.
- Select **Mobile and desktop applications**.
- Choose `https://login.microsoftonline.com/common/oauth2/nativeclient` as the **Redirect URI**.
- Select **Configure** to finish adding the platform.
8. Go to **Credentials & secrets**.
- Select **Client secrets**.
- Click **New client secret**.
- Set a description.
- Click **Add**.
- Don't copy the client secret, adding one is just a requirement from Microsoft.
8. Navigate back to **Overview**.
9. Copy **Application (client) ID**.


Reference: https://docs.microsoft.com/en-us/azure/active-directory/develop/quickstart-register-app

## Adding the Azure Client ID to Helios Launcher.

In `app/assets/js/ipcconstants.js` you'll find **`AZURE_CLIENT_ID`**. Set it to your application's id.

Note: Azure Client ID is NOT a secret value and **can** be stored in git. Reference: https://stackoverflow.com/questions/57306964/are-azure-active-directorys-tenantid-and-clientid-considered-secrets

Then relaunch your app, and login. You'll be greeted with an error message, because the app isn't whitelisted yet. Microsoft needs some activity on the app before whitelisting it. __Trying to log in before requesting whitelist is mandatory.__

## Requesting whitelisting from Microsoft

1. Ensure you have completed every step of this doc page.
2. Fill [this form](https://aka.ms/mce-reviewappid) with required information. Remember this is a new appID for approval. You can find both the Client ID and the Tenant ID on the overview page in the Azure Portal.
3. Give Microsoft some time to review your app.
4. Once you have received Microsoft's approval, allow up to 24 hours for the changes to apply.

----

You can now authenticate with Microsoft through the launcher.
You can now authenticate with Microsoft through the launcher.

References:
- https://docs.microsoft.com/en-us/azure/active-directory/develop/quickstart-register-app
- https://help.minecraft.net/hc/en-us/articles/16254801392141