Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Openssl ver updates #103

Merged
merged 3 commits into from
Apr 26, 2022
Merged

Openssl ver updates #103

merged 3 commits into from
Apr 26, 2022

Conversation

timlegge
Copy link
Contributor

@jonasbn This is just a test for discussion/review. I figured before I (or someone else) started on opensslv3 support it would be good to ensure that the current versioning was correct. This seems to sort a few issue.

I was able to test on:

OpenSSL 1.0.2u 20 Dec 2019
OpenSSL 1.1.1l 24 Aug 2021

Not sure if you have access to 0.9.8 easily. It took me half the evening to get a 1.0.2 environment running.

Both seemed to work fine and the Makefile.Pl has a couple of options to allow testing it a littl better.

At this point I at least none of the earlier deprecated functions should mess with version 3.

Tim
Tim

@jonasbn jonasbn self-assigned this Feb 28, 2022
@jonasbn jonasbn added this to the 1.9.14-TRIAL milestone Apr 26, 2022
@jonasbn jonasbn self-requested a review April 26, 2022 05:23
Copy link
Collaborator

@jonasbn jonasbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need a little cleanup for the Makefilepart, but it looks good

Approved

@jonasbn jonasbn merged commit e0a60a0 into dsully:master Apr 26, 2022
@jonasbn
Copy link
Collaborator

jonasbn commented Apr 26, 2022

Hi @timlegge

This has been included in the release 1.9.14-TRIAL, just uploaded to PAUSE/CPAN.

Please let me know if you experience any issues or have any feedback. The 1.9.14 release will be made in due time depending on the outcome/feedback of the trial release.

Thanks for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants