Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverted changes as proposed by @dakkar in issue #112 #113

Merged
merged 6 commits into from
Jun 19, 2023
Merged

Conversation

jonasbn
Copy link
Collaborator

@jonasbn jonasbn commented Jun 16, 2023

Description

This addressed issue described by @dakkar in issue #112 which break building with Crypt::OpenSSL::Verify

Fixes/addresses (If applicable) #112

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes
  • Changes have been manually tested (please provide information on test platform using the fields below)

Test / Development Platform Information

  • Operating system and version

macOS 13.5 Ventura

  • Crypt::OpenSSL::X509 version

1.9.14 (head)

  • Perl version

5.36.1

  • OpenSSL version

OpenSSL 1.1.1u

Please see the issue template for a more information on provided the requested information.

@dakkar
Copy link

dakkar commented Jun 19, 2023

yep, now it builds, and Crypt-OpenSSL-Verify passes its tests

@timlegge
Copy link
Contributor

Great to hear. Thanks for sorting that

@jonasbn
Copy link
Collaborator Author

jonasbn commented Jun 19, 2023

I will make an official release tonight.

@jonasbn jonasbn merged commit f21789b into master Jun 19, 2023
@jonasbn jonasbn deleted the issue112 branch June 19, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

version 1.9.14 with OpenSSL <1.1.0 breaks Crypt::OpenSSL::Verify
3 participants