Move CPP functions wrapper to dedicated file #452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Y--
force-pushed
the
yl/split-cpp-c-utils
branch
2 times, most recently
from
44dbe37 to
5e6186a
Compare
Y--
force-pushed
the
yl/headers-cpp
branch
4 times, most recently
from
4105f3e to
0f116cc
Compare
Y--
force-pushed
the
yl/split-cpp-c-utils
branch
from
5e6186a to
4649506
Compare
Y--
force-pushed
the
yl/split-cpp-c-utils
branch
from
4649506 to
3dcf221
Compare
Y--
force-pushed
the
yl/split-cpp-c-utils
branch
from
3dcf221 to
3ce1777
Compare
Y--
force-pushed
the
yl/split-cpp-c-utils
branch
from
3ce1777 to
40c7cb1
Compare
JelteF
reviewed
Dec 2, 2024
JelteF
reviewed
Dec 2, 2024
Comment on lines
65
to
66
| edata = CopyErrorData(); | ||
| FlushErrorState(); |
There was a problem hiding this comment.
Semi-related: These two calls should probably also have a PG_TRY around around them in case they fail.
Seems better for a follow-up PR though.
There was a problem hiding this comment.
I can look into this. Will be pretty bad if we hit this though, not sure how we can nicely recover :-)
JelteF
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move CPP function wrapper to dedicated file.
Next, will do the same for the PG wrapper.