Make composites scoped

[randomir]

Also, close #150.

[randomir]

Adding versionadded and note to all composites might be an overkill, let me know what you think, @arcondello, @JoelPasvolsky.

[arcondello]

Way overkill IMO. They publicly inherit, so it suffices to just document on the base class.

[JoelPasvolsky]

Will you be adding the close() method to the docs?

[randomir]

Ok, I removed the note from composites.

TBH, I liked having those specific examples that remind users they should use the new context manager form, but I trust our docs team will illustrate this nicer in a shared/common place.

[randomir]

Will you be adding the close() method to the docs?

I wasn't planning to. We don't have it on dwave-system composites either. Nor we have __enter__/__exit__ (though, I'm not sure these dunder methods should be listed 🤷).

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.53%. Comparing base (1c92e37) to head (607c30c).
Report is 8 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #151      +/-   ##
==========================================
+ Coverage   98.50%   98.53%   +0.03%     
==========================================
  Files          19       20       +1     
  Lines        1002     1026      +24     
==========================================
+ Hits          987     1011      +24     
  Misses         15       15              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[JoelPasvolsky]

Deleted my previous comments, my misunderstanding, sorry

[JoelPasvolsky]

Actually I'm now thinking that the composites do the context management for the user, right? So my previous comments are likely wrong.

[arcondello]

Code seems good! I feel ambivalent about the doc changes.

[randomir]

Actually I'm now thinking that the composites do the context management for the user, right? So my previous comments are likely wrong.

They don't magically wrap children in runtime contexts, if that's what you mean. Users still need to use these composites as context managers in order to trigger close on resources wrapped. Examples in the deleted commit.