Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dyamond2 Example #118

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

Dyamond2 Example #118

wants to merge 21 commits into from

Conversation

sehnem
Copy link
Collaborator

@sehnem sehnem commented Mar 8, 2025

No description provided.

@sehnem
Copy link
Collaborator Author

sehnem commented Mar 8, 2025

@RobertPincus I added the dyamond example to a notebook and loaded using dask, I am just not sure about the data transformations that need to be done for rel and rei, probably will need some help with it.

I created a function to download the data and created this new PR as it rebases the latest changes.

@RobertPincus
Copy link
Member

@sehnem I only have time for a quick peek but it seems the units for cloud optics should be g/m^2 for LWP/IWP and microns (10^-6 m) for particle sizes. I suspect that means you need to compute LWP = (DEPLP * QL)/sci.g * 1000 and pass RL*10e6 to the Python calls.

@RobertPincus
Copy link
Member

@sehnem I've just pushed a commit to address units as per the comment above. You can see if this runs and give reasonable results?

@RobertPincus
Copy link
Member

Seems like this supersedes #114

@tcmetzger tcmetzger linked an issue Mar 11, 2025 that may be closed by this pull request
@sehnem sehnem force-pushed the new-dyamond2-example branch from 6aaeb8c to efb57bd Compare March 15, 2025 21:52
@sehnem sehnem force-pushed the new-dyamond2-example branch from 20ed5cf to 02a56c0 Compare March 16, 2025 03:51
@sehnem sehnem marked this pull request as ready for review March 16, 2025 17:10
@sehnem
Copy link
Collaborator Author

sehnem commented Mar 16, 2025

@RobertPincus I changed all the calls to stack the dimensions that are not core, so you can run dyamond2 without renaming the dimensions Xdim, Ydim and nf and it will call the fortran functions sending the chunks as cols. This was expanded to all the functions making this PR not a small one.

I also made some tests running it with the full Xdim and 300 columns from Ydim and it worked.

I think it should be good for merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve dask example notebooks
2 participants