-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert DBC to json - only 32 characters of Signal Name possible? #230
Comments
Looks ok on the dbc import side. I'll add a long signal name export test for json. |
Alrighty, output alone tests ok as well. @jehoff what version of canmatrix are you using? How did you install it? It's generally best to install from git at this point as opposed to pypi. Also, what exactly are you doing to do the conversion? If you can provide the actual input and output files that would be great, though I understand that's often proprietary data. https://github.com/ebroecker/canmatrix#install-instructions But, I'll check out the convert cli next. |
well, on pypy they worked. fixing to work on all interpreters (or find an issue). |
My stupid tests with "real" dbc also worked - no 32 character limitation. @jehoff search for "FAILURE_ZELL_UNTERTEMPERATUR_ENTLADEN_ALARM_IDX_01" and you will find some "attribute", which holds the long name. |
@altendky @ebroecker Thank you for your help. I checked the .dbc in an editor. Your are right, the signal names are cut in editor (notepad++)! When i open the .dbc in CANdb Editor the signal names are not cut. But there is an attribute, or an explanation in the .dbc file when you open it with an editor:
This is the cooresponding Signal in .dbc file (Editor)
I think CANdb Editor is working with this "explanation" , to show the long signal name in CANdb Editor. Notepad (Attribute SystemSignalLongSymbol) I use canmatrix 0.6, installed with pypi on Windows 7 |
@jehoff
Thanks for your Analysis.
I'll create a fix for this issue!
Am 2. November 2018 09:15:33 MEZ schrieb jehoff <[email protected]>:
…
@altendky @ebroecker Thank you for your helfp. I checked the .dbc in
an editor. Your are right, the signal names are cut in editor
(notepad++)! When i open the .dbc in CANdb Editor the signal names are
not cut.
The problem is the .dbc file, ... too long signal names.
But there is an attribute, or an explanation in the .dbc file when you
open it with an editor:
> BA_ "SystemSignalLongSymbol" SG_ 193 FAILURE_ZELL_UNTERTEMPERATU_0043
"FAILURE_ZELL_UNTERTEMPERATUR_LADEN_WARNUNG_IDX_01";
This is the Signal name in .dbc
> SG_ FAILURE_ZELL_UNTERTEMPERATU_0043 : ***@***.***+ (1,0) [0|1] "Warnung"
BMS_MASTER
I think CANdb Editor is working with this, to show the long signal
name.
I use canmatrix 0.6, installed with pip on Windows 7
Thanks for your fast reply!
Notepad (Screenshot)

CANdb Editor (Screenshot)

Notepad (Attribute SystemSignalLongSymbol)

--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#230 (comment)
--
sent from mobile device
|
simmilar issue exists for:
|
When I convert one of our .dbc files into json format, the signal names are cut.
They are too long. I know Vector Informatik wants the signal names not longer than 32 characters. But .dbc files work with signal names longer than 32 characters.
Would it be possible to change this limitation to 64 characters in canmatrix?
Or maybe somebody can tell me where to change this limitation of 32 characters in the code?
I like canmatrix, but i cant separate/find signals with this limitation.
When i convert with canmatrix i got this in example:
"name": "FAILURE_ZELL_UNTERTEMPERATU_0042"
in .dbc file it could be:
"FAILURE_ZELL_UNTERTEMPERATUR_ENTLADEN_ALARM_IDX_01"
or
"FAILURE_ZELL_UNTERTEMPERATUR_ENTLADEN_WARNUNG_IDX_01"
or
"FAILURE_ZELL_UNTERTEMPERATUR_LADEN_ALARM_IDX_01"
or
"FAILURE_ZELL_UNTERTEMPERATUR_LADEN_WARNUNG_IDX_01"
Is it possible to change the limitation of 32 characters per signal name?
The text was updated successfully, but these errors were encountered: