Report_error in decode should throw an exception.

[timschneider]

canmatrix/src/canmatrix/canmatrix.py

Lines 1008 to 1035 in b21a9ed

	def decode(self, data):
	"""Return OrderedDictionary with Signal Name: object decodedSignal (support for multiplexed frames)
	decodes only signals matching to muxgroup
	:param data: bytearray .
	i.e. bytearray([0xA1, 0xA2, 0xA3, 0xA4, 0xA5, 0xA6, 0xA7, 0xA8])
	:return: OrderedDictionary
	"""
	decoded = self.unpack(data)
	if self.is_complex_multiplexed:
	# TODO
	raise DecodingComplexMultiplexed
	elif self.is_multiplexed:
	returnDict = dict()
	# find multiplexer and decode only its value:
	for signal in self.signals:
	if signal.is_multiplexer:
	muxVal = decoded[signal.name].raw_value
	# find all signals with the identified multiplexer-value
	for signal in self.signals:
	if signal.mux_val == muxVal or signal.mux_val is None:
	returnDict[signal.name] = decoded[signal.name]
	return returnDict
	else:
	return decoded

Without an additional parameter we should disable report_error by default in decoded = self.unpack(data, False)

canmatrix/src/canmatrix/canmatrix.py

Lines 994 to 995 in b21a9ed

	print(
	'Received message 0x{self.id:08X} with length {rx_length}, expected {self.size}'.format(**locals()))

Should throw an exception.

[altendky]

I agree with an exception over a print, but why should errors pass silently by default?

[timschneider]

no sorry, this was just an intuitive way of reporting this "situation" like, oh, wait, no I see an output on the screen, what the heck? oh, ok it’s a debug output, but wait, how can I handle it? ummm, no way, cause it's a print - ok then turn it off and check it upfront. I don’t want to pass it silently.

So I think an exception is the way we should go.

Because my DBC Files are full of invalid Message Length and still valid, so I see a lot of output on the screen :)

[ebroecker]

fixed