Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor accessing dict items #321

Closed
Funth0mas opened this issue Mar 6, 2019 · 3 comments
Closed

Refactor accessing dict items #321

Funth0mas opened this issue Mar 6, 2019 · 3 comments
Milestone

Comments

@Funth0mas
Copy link
Contributor

refactor
if "ATTRIBUTE" in ignore and ignore["ATTRIBUTE"] == "*"
to
if ignore.get("ATTRIBUTE") == "*"

everywhere

@ebroecker ebroecker added this to the 0.8 milestone Mar 9, 2019
@ebroecker
Copy link
Owner

@Funth0mas
Is this still somewhere wrong ?

@Funth0mas
Copy link
Contributor Author

I havent targeted this issue so I don't expect that it is fully solved. I meant that like a reminder based on former reviews. First I wanted to finish the annotation but I did not managet it yet.

And yes I matched some of them using regex "(\w+)" +in.*\["\1" from total commander for example.

ebroecker added a commit that referenced this issue Mar 28, 2019
ebroecker added a commit that referenced this issue Mar 29, 2019
ebroecker added a commit that referenced this issue Apr 5, 2019
@ebroecker
Copy link
Owner

done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants