Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add min and max to jsonAll export #275 #276

Merged
merged 11 commits into from
Feb 9, 2019
Merged

add min and max to jsonAll export #275 #276

merged 11 commits into from
Feb 9, 2019

Conversation

ebroecker
Copy link
Owner

@ebroecker ebroecker commented Jan 15, 2019

fixes

  • min and max for json import/export
  • add tests for this
  • remove import * from canmatrix

@codecov-io
Copy link

codecov-io commented Jan 15, 2019

Codecov Report

Merging #276 into development will decrease coverage by 0.95%.
The diff coverage is 76.66%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #276      +/-   ##
===============================================
- Coverage        32.31%   31.35%   -0.96%     
===============================================
  Files               32       33       +1     
  Lines             6529     6917     +388     
  Branches          1626     1851     +225     
===============================================
+ Hits              2110     2169      +59     
- Misses            4223     4484     +261     
- Partials           196      264      +68
Impacted Files Coverage Δ
src/canmatrix/tests/test_cmjson.py 100% <100%> (ø) ⬆️
src/canmatrix/cmjson.py 67.22% <50%> (+15.94%) ⬆️
src/canmatrix/utils.py 90.47% <0%> (-9.53%) ⬇️
src/canmatrix/tests/test_utils.py 100% <0%> (ø)
src/canmatrix/arxml.py 0.55% <0%> (ø) ⬆️
src/canmatrix/formats.py 56.04% <0%> (+6.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 616ec80...291b88d. Read the comment docs.

@ebroecker ebroecker requested a review from altendky January 15, 2019 19:59
@ebroecker ebroecker merged commit c488545 into development Feb 9, 2019
@ebroecker ebroecker deleted the iss275 branch February 14, 2019 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants