Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix creating dbc files. #337

Merged
merged 2 commits into from
Mar 28, 2019
Merged

Conversation

ebroecker
Copy link
Owner

  • arbitration_id instead of combound arbitration id was used in several cases
  • ecu attribute definitions were not written, inspite signal attribute definitions were
    written

ecu attribute definitions were not written, inspite signal attribute definitions were
written
@codecov-io
Copy link

codecov-io commented Mar 28, 2019

Codecov Report

Merging #337 into development will not change coverage.
The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff              @@
##           development     #337   +/-   ##
============================================
  Coverage        40.18%   40.18%           
============================================
  Files               35       35           
  Lines             7053     7053           
  Branches          1669     1669           
============================================
  Hits              2834     2834           
  Misses            4010     4010           
  Partials           209      209
Impacted Files Coverage Δ
src/canmatrix/formats/dbc.py 52.4% <50%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 904b289...33b2bf9. Read the comment docs.

@ebroecker ebroecker merged commit 2e7a61c into development Mar 28, 2019
@ebroecker ebroecker deleted the dbc_write_fixes_ecu_attributes branch March 28, 2019 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants