Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use non-deprecated versions of vim.validate #1533

Closed
wants to merge 1 commit into from

Conversation

dundargoc
Copy link
Contributor

@dundargoc dundargoc commented Jan 28, 2025

This will remove stack traces from :checkhealth vim.deprecated.

This will remove stack traces from `:checkhealth vim.deprecated`.
@dundargoc dundargoc changed the title fix: use non-deprecated versions of vim.validate for newer neovim versions fix: use non-deprecated versions of vim.validate Jan 28, 2025
@dundargoc
Copy link
Contributor Author

dundargoc commented Jan 28, 2025

I only focused on the modules I use to gauge interest. I can do it for the rest as well if wanted.

@dundargoc dundargoc marked this pull request as ready for review January 28, 2025 12:22
@echasnovski
Copy link
Owner

Thanks for the PR!

This is an interesting coincidence, as I am right now fixing this with a bit more scope in mind (fully switching to custom helper and unifying error handling across modules). So I am afraid I'm going to close this.

@echasnovski
Copy link
Owner

@dundargoc, this should now be fixed on latest main. 0de7ac9 is what I had in mind, if you are curious.

@dundargoc
Copy link
Contributor Author

Looks good. Mostly curious, are you planning to re-use vim.validate once the minimum supported version is large enough or is this for long-term usage?

@dundargoc dundargoc deleted the fix/vim.validate branch January 31, 2025 21:08
@echasnovski
Copy link
Owner

With the current Neovim release schedule, this will happen in about two years (after possible 0.13.0 release). So I'll refrain from making such long term prediction :)

The advantages of current approach are that type checking errors neatly have (mini.xxx) prefix and it is even faster than the current Nightly fast vim.validate(). The disadvantage is that it requires 5 extra line per module (i.e. 200+ lines per 'mini.nvim'). Probably keeping current solution is fine, but we'll see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants