Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Asset Interfaces Description (AID) submodel #1222

Merged
merged 5 commits into from
Jan 23, 2024

Conversation

danielpeintner
Copy link
Member

fixes #1220

Copy link

codecov bot commented Jan 19, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (c130878) 77.75% compared to head (6c9f021) 77.73%.

Files Patch % Lines
...s/td-tools/src/util/asset-interface-description.ts 71.42% 6 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1222      +/-   ##
==========================================
- Coverage   77.75%   77.73%   -0.02%     
==========================================
  Files          84       84              
  Lines       17444    17448       +4     
  Branches     1765     1767       +2     
==========================================
  Hits        13564    13564              
- Misses       3844     3848       +4     
  Partials       36       36              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielpeintner
Copy link
Member Author

@Kaz040 please have a look

Note: I think all aspects are handled, some terms like created, modified etc were not there before. Maybe we can add them later in a follow-up PR.

I also had to update the JSON Schema, see https://github.com/eclipse-thingweb/node-wot/pull/1222/files#diff-e8f82d52b6ce8affc67a761291254515c7bf70157338602673288f93a32fb45b
The only thing is missing are the 2 new terms mostSignificantByte and mostSignificantWord for Modbus. Do you want to update the JSON I already modified with those 2 missing changes?

Copy link
Contributor

@Kaz040 Kaz040 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my side. everything seems ok according to the changes.

@danielpeintner
Copy link
Member Author

@sebastiankb fine with merging too?

@sebastiankb
Copy link
Contributor

PR looks good. Ready for merge

@danielpeintner danielpeintner merged commit 33be732 into eclipse-thingweb:master Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changes update of Asset Interfaces Description (AID) submodel
3 participants