-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Asset Interfaces Description (AID) submodel #1222
Update Asset Interfaces Description (AID) submodel #1222
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1222 +/- ##
==========================================
- Coverage 77.75% 77.73% -0.02%
==========================================
Files 84 84
Lines 17444 17448 +4
Branches 1765 1767 +2
==========================================
Hits 13564 13564
- Misses 3844 3848 +4
Partials 36 36 ☔ View full report in Codecov by Sentry. |
@Kaz040 please have a look Note: I think all aspects are handled, some terms like I also had to update the JSON Schema, see https://github.com/eclipse-thingweb/node-wot/pull/1222/files#diff-e8f82d52b6ce8affc67a761291254515c7bf70157338602673288f93a32fb45b |
…d modbusMostSignificantWordElement
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From my side. everything seems ok according to the changes.
@sebastiankb fine with merging too? |
PR looks good. Ready for merge |
fixes #1220