Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for next release with new minor version 0.9.0 #1346

Merged

Conversation

danielpeintner
Copy link
Member

Minor version change needed due to
#1332

@danielpeintner
Copy link
Member Author

FYI: Locally, I got once an error that I haven't been seeing before

grafik

For the CI it seems to work fine... maybe just an outlier

@JKRhb
Copy link
Member

JKRhb commented Jan 30, 2025

Thank you for preparing the new release, @danielpeintner! I just ran the tests locally (under Linux with Node 22) and there they passed :) Does increasing the timeout maybe have an influence on whether the test is failing?

@danielpeintner
Copy link
Member Author

Thank you for preparing the new release, @danielpeintner! I just ran the tests locally (under Linux with Node 22) and there they passed :) Does increasing the timeout maybe have an influence on whether the test is failing?

Mhh, not sure if we should do anything. Re-running the tests didn't cause anymore the issue locally. Maybe it was just something temporarily broken on my machine, but I thought I share it anyway

@relu91
Copy link
Member

relu91 commented Jan 30, 2025

I think the problem is that the failing test is leveraging on the fact that the TM is not available under example.com . It is a pretty weak assumption and it depends on the fact of running tets with an active internet connection. we could design it better ... but we can still live with it.

@danielpeintner danielpeintner merged commit 4d083fc into eclipse-thingweb:master Jan 31, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants