-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented new package to sync to external repositories #122
Implemented new package to sync to external repositories #122
Conversation
✅ Deploy Preview for thingweb ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good but one question: should we commit API.md here or just keep it in the source?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! a couple of questions before moving on:
- It seems that we changed the structure (Docs -> node-wot -> API to Docs -> API), we should configure the plugin to have different folders for different repositories (I guess you can just add an entry for each right?)
- How to handle versioning? if it is still something to figure out that's ok
- Since it is duplicated content, I would like to gitignore the pulled content from remote repositories (if possible)
- How would the release process look like? Should we manually trigger a release every time a doc is updated in the remote repository?
@relu91 the "plugin" is a rather stupid one :D I think we can just do some bash scripts and wget instead of this. There is no real automation, versioning etc. at the moment. Some concrete answers:
I agree.
Currently, each time the page is built, the remote documents are pulled.
A solution, without reading anything, would be to version the documents in the remote repositories and add different download targets in the config here. Looking at https://docusaurus.io/docs/versioning we should simply do something like that. |
That's ok for now.
Good, we can start organizing it for node-wot. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the last step is to .gitignore files pulled with the docusaurus-plugin-remote-content
and we are good to go.
@relu91 , would you prefer to ignore the API.md file only, or should we ignore everything in the docs folder? |
I think given that we settled to trust completely what is coming from the target repository we can ignore the whole folder. Then in the future, we can host a docs folder in node-wot, to be carried over and have a 1-1 mapping. Therefore, in node-wot we will put also configuration files for docusourus. @egekorkan what do you think? |
I agree that the structure and content should come from node-wot repository. However, what docusaurus files you want to put there @relu91 ? EDIT: We can ignore the whole folder :) |
I don't know, but reading https://docusaurus.io/docs/versioning I saw that you can also configure the sidebar with some json... I was thinking about that.
Good. |
The entire docs folder should now be ignored. For future docs organization, if you want to put documentation in a specific folder (like a "node-wot"), just remember to add a category.json file. This ensures the sidebar has the right name and position. Here’s an example of what it should look like: {
"label": "node-wot",
"position": 2,
"link": {
"type": "generated-index"
}
} |
This should work now. |
Also having the If we want to keep this, we can either:
|
I think we should go with this direction in the repositories. EDIT: However, we should make sure that the value of position is not conflicting between repositories |
The package docusaurus-plugin-remote-content was implemented to read and duplicate markdown files from external repositories.