Skip to content

Improve workflows #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Improve workflows #30

wants to merge 10 commits into from

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Apr 22, 2025

This fixes/improves a number of items for CI:

  1. Updates to current versions of actions (the old versions use obsolete versions of node and github wants to drop support for them)
  2. Moves away from using ${{ ... }} in run: statements (which is considered bad practice)
  3. Uses github.token instead of secrets.GITHUB_TOKEN -- they reference the same thing but the former should be preferred
  4. Moves name: field before run:
  5. Adds permissions to jobs
  6. Makes workflow stop if it can't publish
    The existing workflow behavior for ci.yml is to run for 6 hours (the default github workflow time limit) which is really expensive as it blocks one of a user's 20 runner slots for 6 hours.

Note that this is only mostly tested. I can't get various things to pass -- some things appear to expect to run in this repository, and a bunch of things require pre-existing releases and I couldn't figure out how to synthesize those either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant