FEATURE/HCMPRE-1635: Updated versions with fixes #2028
Conversation
Co-authored-by: Nipun Arora <[email protected]>
* Update MicroplanSearch.js * Pagination issues --------- Co-authored-by: Nipun Arora <[email protected]>
* Revert "Bugfix/hcmpre 1583 (#2021)" This reverts commit 201a0ce. * BUGFIX/HCMPRE-1634 Revert ing"updated core version (#2020)" * BUGFIX/HCMPRE-1583 fixes --------- Co-authored-by: Swathi-eGov <[email protected]>
FEATURE/HCMPRE-1634: Fixed all the version updates
📝 WalkthroughWalkthroughThis pull request involves updates to multiple files in the health micro-ui project. The changes primarily focus on two main aspects: updating CSS stylesheet versions in Changes
Possibly related PRs
Suggested reviewers
Poem
Tip CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Swathi-eGov
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 5
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
⛔ Files ignored due to path filters (9)
health/micro-ui/web/core/package.jsonis excluded by!**/*.jsonhealth/micro-ui/web/micro-ui-internals/example/package.jsonis excluded by!**/*.jsonhealth/micro-ui/web/micro-ui-internals/package.jsonis excluded by!**/*.jsonhealth/micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/package.jsonis excluded by!**/*.jsonhealth/micro-ui/web/micro-ui-internals/packages/modules/microplan/package.jsonis excluded by!**/*.jsonhealth/micro-ui/web/micro-ui-internals/packages/modules/workbench-hcm/package.jsonis excluded by!**/*.jsonhealth/micro-ui/web/microplan/package.jsonis excluded by!**/*.jsonhealth/micro-ui/web/package.jsonis excluded by!**/*.jsonhealth/micro-ui/web/workbench/package.jsonis excluded by!**/*.json
📒 Files selected for processing (4)
health/micro-ui/web/micro-ui-internals/example/public/index.html(1 hunks)health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/MicroplanSearch.js(2 hunks)health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/MyMicroplans.js(1 hunks)health/micro-ui/web/public/index.html(1 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/MicroplanSearch.js (1)
Pattern **/*.js: check
health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/MyMicroplans.js (1)
Pattern **/*.js: check
🪛 Biome (1.9.4)
health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/MyMicroplans.js
[error] 26-26: Unnecessary use of boolean literals in conditional expression.
Simplify your code by directly assigning the result without using a ternary operator.
If your goal is negation, you may use the logical NOT (!) or double NOT (!!) operator for clearer and concise code.
Check for more details about NOT operator.
Unsafe fix: Remove the conditional expression with
(lint/complexity/noUselessTernary)
🔇 Additional comments (2)
health/micro-ui/web/micro-ui-internals/example/public/index.html (1)
14-15: 🧹 Nitpick (assertive)
Verify stylesheet version availability and compatibility
The stylesheet versions have been updated:
- digit-ui-components-css: beta.42 → beta.43
- digit-ui-health-css: 0.2.2 → 0.2.3
Consider implementing a version pinning strategy using package.json to manage CSS dependencies more reliably, rather than directly referencing unpkg URLs. This would provide better control over updates and make it easier to track changes.
✅ Verification successful
Stylesheet versions are accessible and working
Both updated stylesheet versions are accessible and return successful HTTP 200 responses:
- @egovernments/[email protected]
- @egovernments/[email protected]
While the version updates are minor and the resources are available, consider managing these dependencies through package.json for better version control and dependency tracking.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify the availability of the updated stylesheet versions and check for any breaking changes
# Check if the new stylesheet versions are accessible
echo "Checking [email protected]..."
curl -s -o /dev/null -w "%{http_code}" https://unpkg.com/@egovernments/[email protected]/dist/index.css
echo "Checking [email protected]..."
curl -s -o /dev/null -w "%{http_code}" https://unpkg.com/@egovernments/[email protected]/dist/index.css
# Look for changelog or version information in the repository
fd -t f "CHANGELOG.md|package.json" | xargs rg -A 5 "0.0.2-beta.43|0.2.3"
Length of output: 1861
health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/MyMicroplans.js (1)
24-32: 🛠️ Refactor suggestion
Add error handling for URL manipulation and cleanup.
The URL manipulation in onTabChange could fail in certain scenarios. Additionally, the commented configuration code might indicate incomplete implementation.
Consider these improvements:
- Add try-catch for URL manipulation
- Add cleanup in useEffect
- Clarify the intention of the commented configuration code
🧰 Tools
🪛 Biome (1.9.4)
[error] 26-26: Unnecessary use of boolean literals in conditional expression.
Simplify your code by directly assigning the result without using a ternary operator.
If your goal is negation, you may use the logical NOT (!) or double NOT (!!) operator for clearer and concise code.
Check for more details about NOT operator.
Unsafe fix: Remove the conditional expression with
(lint/complexity/noUselessTernary)
...icro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/MyMicroplans.js
Show resolved
Hide resolved
...icro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/MyMicroplans.js
Show resolved
Hide resolved
...o-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/MicroplanSearch.js
Show resolved
Hide resolved
...o-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/MicroplanSearch.js
Show resolved
Hide resolved
jagankumar-egov
changed the title
Choose the appropriate template for your PR:
Feature PR
Feature Request
JIRA ID
Module
Description
Related Issues
Bugfix PR
Bugfix Request
JIRA ID
Module
Description
Root Cause
Related Issues
Release PR
Summary by CodeRabbit
New Features
Bug Fixes