Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[breaking change] pass $event instead of the item entry #43

Closed
eidng8 opened this issue Apr 24, 2020 · 0 comments
Closed

[breaking change] pass $event instead of the item entry #43

eidng8 opened this issue Apr 24, 2020 · 0 comments
Labels
enhancement New enhancement or request
Milestone
1.0.0

Comments

@eidng8
Copy link
Owner

eidng8 commented Apr 24, 2020

Now events just pass the item entry downstream. It's better to pass custom event with the item set in the data field.
@eidng8 eidng8 added the enhancement New enhancement or request label Apr 24, 2020
@eidng8 eidng8 added this to the 1.0.0 milestone Apr 24, 2020
eidng8 added a commit that referenced this issue Apr 26, 2020
@eidng8
fix #43 #42

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
88ec422
eidng8 added a commit that referenced this issue Apr 26, 2020
@eidng8
fix #43

Verified

This commit was signed with the committer’s verified signature.
BurntSushi Andrew Gallant
GPG key ID: B2E3A4923F8B0D44
Verified
Learn about vigilant mode
863c044
eidng8 added a commit that referenced this issue Apr 27, 2020
@eidng8
fix #43 #42

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
58efea5
@eidng8 eidng8 changed the title pass $event instead of the item entry [breaking] pass $event instead of the item entry Apr 27, 2020
@eidng8 eidng8 changed the title [breaking] pass $event instead of the item entry [breaking change] pass $event instead of the item entry Apr 27, 2020
@eidng8 eidng8 mentioned this issue Apr 27, 2020
Merged
@eidng8 eidng8 closed this as completed in 0d16eda Apr 27, 2020
eidng8 added a commit that referenced this issue Apr 27, 2020
@eidng8
Merge pull request #45 from eidng8/dev
60fd73c 
fix #42 #43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New enhancement or request
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
1 participant
@eidng8