Fix failure when VPC CNI is configured to use both iam.withOIDC and useDefaultPodIdentityAssociations #8249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryantbiggs
reviewed
Feb 25, 2025
dims
force-pushed
the
remove-unnecessary-check-for-oidc-provider-during-cluster-creation
branch
from
fbcc0c7 to
493e238
Compare
dims
changed the title
…seDefaultPodIdentityAssociations Signed-off-by: Davanum Srinivas <[email protected]>
dims
force-pushed
the
remove-unnecessary-check-for-oidc-provider-during-cluster-creation
branch
from
493e238 to
93ba3bc
Compare
bryantbiggs
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref: #8147
This explicit check comes at a time when the OIDC endpoint is getting created (and may not have been yet!), so we end up getting
but since OIDC is disabled on the clustermessage which is not really true, because we did ask the cluster to be created withcfg.IAM.WithOIDCset to true!xref: #8141
During create, we were passing
podIdentityIAMUpdaterto be nil which caused the panic.