Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update zz_generated.deepcopy.go, also add new make target for the same #8267

Merged
merged 1 commit into from
Mar 3, 2025
Merged

Update zz_generated.deepcopy.go, also add new make target for the same #8267

merged 1 commit into from
Mar 3, 2025

Conversation

dims
Copy link
Contributor

@dims dims commented Feb 28, 2025

For now, let's leave this as a manual step we have to remember to do.

@dims dims requested a review from cheeseandcereal February 28, 2025 21:27
@dims dims force-pushed the update-zz_generated.deepcopy.go-also-add-new-make-target-for-the-same branch from 72d6ecf to 2fefd27 Compare February 28, 2025 21:29
cheeseandcereal
cheeseandcereal approved these changes Mar 3, 2025
View reviewed changes
Copy link
Member

@cheeseandcereal cheeseandcereal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We can figure out how to better integrate this into our workflows (aside from just manually running) later. New target lgtm though.

@dims dims merged commit a7ee2ea into eksctl-io:main Mar 3, 2025
9 checks passed
@eksctl-bot eksctl-bot mentioned this pull request Mar 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cheeseandcereal cheeseandcereal cheeseandcereal approved these changes

Assignees

@bryantbiggs bryantbiggs

Labels
kind/improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dims @cheeseandcereal @bryantbiggs