Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update goformation from latest schema / Remove unused generated code #8289

Merged
merged 4 commits into from
Mar 7, 2025

Conversation

dims
Copy link
Contributor

@dims dims commented Mar 5, 2025

We have TON of code we generate but do not use. So let's clean it up.

  • Add an Allow list in generate.go with just the services that we need/use in this repo.
  • Run go:generate in goformation.go to generate from latest schema
  • Adjust some of the existing code as the struct(s) have changed a bit.

Only the first commit is useful to review. The second commit is mechanical output from go:generate.

@dims dims requested a review from cheeseandcereal March 5, 2025 22:30
@dims dims changed the title Update goformation from latest schema Update goformation from latest schema / Remove unused generated code Mar 5, 2025
@dims dims force-pushed the update-goformation-from-latest-schema branch from 8e9370c to 9675430 Compare March 6, 2025 01:52
@dims dims force-pushed the update-goformation-from-latest-schema branch from 9675430 to d8c49c2 Compare March 6, 2025 02:03
dims added 2 commits March 5, 2025 21:15
Signed-off-by: Davanum Srinivas <[email protected]>
@cheeseandcereal
Copy link
Member

Because of the # of files, changed, I can't view the whole thing on github. I will download it and check.

Can you help point me to the non-generated/interesting/important files to review for changes in this CR @dims ?

@dims
Copy link
Contributor Author

dims commented Mar 6, 2025

@cheeseandcereal skip d8c49c2 commit, the rest of the 3 commits are easily reviewable in GH or locally.

Copy link
Member

@cheeseandcereal cheeseandcereal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! Thanks for the code reaping!

@dims dims merged commit 1b58c42 into eksctl-io:main Mar 7, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants