Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow core/default networking addons on auto-mode clusters with mixed node types #8293

Merged
merged 1 commit into from
Mar 12, 2025

Conversation

cheeseandcereal
Copy link
Member

Description

Fixes #8292

This PR allows the creation of default addons on clusters configured for auto mode, if they also have other compute types configured (specifically fargate profiles or hybrid nodes remote networking config, since self managed/managed nodes are not allowed to be created with auto mode clusters).

This also updates the check to only check for non-auto default addons, instead of all default addons. This allows creating, for example, metrics-server, which is a default addon which should be able to be created with auto-mode only clusters.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@cheeseandcereal cheeseandcereal merged commit 6052a6d into main Mar 12, 2025
11 checks passed
@cheeseandcereal cheeseandcereal deleted the allow-networking-addons-with-mixed-clusters branch March 12, 2025 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants