Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test github commands #1

Closed
wants to merge 11 commits into from
Closed

test github commands #1

wants to merge 11 commits into from

Conversation

v1v
Copy link
Contributor

@v1v v1v commented Mar 30, 2023

No description provided.

@v1v
Copy link
Contributor Author

v1v commented Mar 30, 2023

/test module

@v1v
Copy link
Contributor Author

v1v commented Mar 30, 2023

/test module

@v1v
Copy link
Contributor Author

v1v commented Mar 30, 2023

/test module

* origin/main:
  action: grant more permissions
@v1v
Copy link
Contributor Author

v1v commented Mar 30, 2023

/test module

@v1v
Copy link
Contributor Author

v1v commented Mar 30, 2023

/test module

@github-actions
Copy link

Only users with write permission to the respository can run /test module

* origin/main:
  notify status
  run if possible
@v1v
Copy link
Contributor Author

v1v commented Mar 30, 2023

/test module

@v1v
Copy link
Contributor Author

v1v commented Mar 30, 2023

/test module

@trentm
Copy link

trentm commented Mar 30, 2023

/test module foo,bar,baz

@github-actions
Copy link

Only users with write permission to the respository can run /test module

@trentm
Copy link

trentm commented Mar 30, 2023

Does this /test module trigger it?

@github-actions
Copy link

Only users with write permission to the respository can run /test module

@trentm
Copy link

trentm commented Mar 30, 2023

What about this /test module? I hope not.

@github-actions
Copy link

Only users with write permission to the respository can run /test module

@v1v
Copy link
Contributor Author

v1v commented Mar 30, 2023

What about this /test module? I hope not.

@v1v
Copy link
Contributor Author

v1v commented Mar 30, 2023

@trentm , i was relaxed with the condition see ea10d4c

@v1v
Copy link
Contributor Author

v1v commented Mar 30, 2023

/test module

@trentm
Copy link

trentm commented Mar 30, 2023

@v1v That is better, but doing == won't work if/when we want to add /test module redis,ioredis for example.
What about something like

contains('\n' + github.event.comment.body, '\n/test module')

This would catch usage of "/test module" at the start of a line.

@v1v
Copy link
Contributor Author

v1v commented Mar 30, 2023

This would catch usage of "/test module" at the start of a line.

That's a good one, we can also use startsWith as an alternative

@trentm
Copy link

trentm commented Mar 30, 2023

That's a good one, we can also use startsWith as an alternative

Yup. startsWith would mean the /test ... has to be on the first line. That would be fine too.

@v1v
Copy link
Contributor Author

v1v commented May 8, 2023

/test module

Copy link
Contributor Author

@v1v v1v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test module

@v1v v1v closed this May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants