Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps-dev): bump undici from 6.2.1 to 6.3.0 #3827

Merged
merged 3 commits into from
Jan 16, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
correct the 'Error.prepareStackTrace is not set' test assumptions, no…
…de v21.6.0 sets a default Error.prepareStackTrace
trentm committed Jan 15, 2024
commit b8daf0385e5b40dd7df28ce9d8230225608bcac1
63 changes: 36 additions & 27 deletions test/stacktraces/stacktraces.test.js
Original file line number Diff line number Diff line change
@@ -22,6 +22,12 @@ const {
stackTraceFromErrStackString,
} = require('../../lib/stacktraces');

// Determine Node.js's default `Error.prepareStackTrace` value before any
// tests run that might start the agent, which changes this value.
const defaultNodePrepareStackTraceStr = Error.prepareStackTrace
? Error.prepareStackTrace.name
: 'undefined';

const log = logging.createLogger('off');

// Execute 'node fixtures/throw-an-error.js' and assert APM server gets the
@@ -452,7 +458,7 @@ tape.test('gatherStackTrace()', function (suite) {
});
});

tape.test('Error.prepareStackTrace is set', function (t) {
tape.test('Error.prepareStackTrace is set when agent active', function (t) {
const server = new MockAPMServer();
server.start(function (serverUrl) {
execFile(
@@ -479,32 +485,35 @@ tape.test('gatherStackTrace()', function (suite) {
});
});

tape.test('Error.prepareStackTrace is not set', function (t) {
const server = new MockAPMServer();
server.start(function (serverUrl) {
execFile(
process.execPath,
['fixtures/get-prepare-stacktrace.js'],
{
cwd: __dirname,
timeout: 3000,
env: Object.assign({}, process.env, {
ELASTIC_APM_ACTIVE: false,
}),
},
function done(err, _stdout, _stderr) {
t.ok(!err);
t.equals(
_stdout.trim(),
'undefined',
'Error.prepareStackTrace is not set',
);
server.close();
t.end();
},
);
});
});
tape.test(
'Error.prepareStackTrace is Node.js default when agent is inactive',
function (t) {
const server = new MockAPMServer();
server.start(function (serverUrl) {
execFile(
process.execPath,
['fixtures/get-prepare-stacktrace.js'],
{
cwd: __dirname,
timeout: 3000,
env: Object.assign({}, process.env, {
ELASTIC_APM_ACTIVE: false,
}),
},
function done(err, _stdout, _stderr) {
t.ok(!err);
t.equals(
_stdout.trim(),
defaultNodePrepareStackTraceStr,
'Error.prepareStackTrace is the Node.js default',
);
server.close();
t.end();
},
);
});
},
);

suite.end();
});