Updated Go to version 1.5.1 #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because the toolchain bootstraping process changed in Go 1.5, this change imports the "pure bootstraper" from the https://github.com/karalabe/xgo project. There's also Go 1.5 bug that required adding the `ldflags=-s` flag for OS X: golang/go#11994
| # - make push-images | ||
| #- docker login -e="$DOCKER_EMAIL" -u="$DOCKER_USERNAME" -p="$DOCKER_PASSWORD" | ||
| #- make images | ||
| #- make push-images |
There was a problem hiding this comment.
maybe we can make this enable by a variable to be configured from command line?
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the toolchain bootstraping process changed in Go 1.5, this change imports the "pure bootstraper" from the https://github.com/karalabe/xgo project.
There's also Go 1.5 bug that required adding the
ldflags=-sflag for OS X: golang/go#11994The new Docker images are already pushed to the docker hub.