Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESQL: TO_LOWER and TO_UPPER should keep multivalued fields #124002

Open
nik9000 opened this issue Mar 4, 2025 · 1 comment · May be fixed by #124676
Open

ESQL: TO_LOWER and TO_UPPER should keep multivalued fields #124002

nik9000 opened this issue Mar 4, 2025 · 1 comment · May be fixed by #124676
Labels
:Analytics/ES|QL AKA ESQL >enhancement Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo)

Comments

@nik9000
Copy link
Member

nik9000 commented Mar 4, 2025

Description

ESQL's TO_LOWER and TO_UPPER should process each value in a multivalued field - all functions withTO_ in the name do that except these. There isn't a real rule for this at the moment, but we should make one.
@nik9000 nik9000 added >enhancement needs:triage Requires assignment of a team area label :Analytics/ES|QL AKA ESQL and removed needs:triage Requires assignment of a team area label labels Mar 4, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Mar 4, 2025
nik9000 added a commit to nik9000/elasticsearch that referenced this issue Mar 12, 2025
@nik9000
ESQL: TO_LOWER processes all values
59f3d22 
Make `TO_LOWER` and `TO_UPPER` process all values it received.

This is quite large because it borrows a lot of code from the regular
evaluator generator to generate conversions so we can use the Locale.
That change propagates to the order of some parameters and to the
`toString` and a few more places.

Closes elastic#124002
@nik9000 nik9000 linked a pull request Mar 12, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:Analytics/ES|QL AKA ESQL >enhancement Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ESQL: TO_LOWER process all values nik9000/elasticsearch
2 participants
@nik9000 @elasticsearchmachine