Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESQL: TO_LOWER process all values #124676

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

nik9000
Copy link
Member

@nik9000 nik9000 commented Mar 12, 2025

Make TO_LOWER and TO_UPPER process all values it receives.

This is quite large because it borrows a lot of code from the regular evaluator generator to generate conversions so we can use the Locale. That change propagates to the order of some parameters and to the toString and a few more places.

Closes #124002

nik9000 added 2 commits March 12, 2025 16:06
Make `TO_LOWER` and `TO_UPPER` process all values it received.

This is quite large because it borrows a lot of code from the regular
evaluator generator to generate conversions so we can use the Locale.
That change propagates to the order of some parameters and to the
`toString` and a few more places.

Closes elastic#124002
@nik9000 nik9000 requested a review from bpintea March 12, 2025 20:13
@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Mar 12, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@elasticsearchmachine
Copy link
Collaborator

Hi @nik9000, I've created a changelog YAML for you.

@nik9000 nik9000 changed the title ESQL: TO_LOWER processes all values ESQL: TO_LOWER process all values Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/ES|QL AKA ESQL >bug Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ESQL: TO_LOWER and TO_UPPER should keep multivalued fields
2 participants