Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Eclipse instructions #53667

Merged
merged 1 commit into from
Mar 17, 2020
Merged

Drop Eclipse instructions #53667

merged 1 commit into from
Mar 17, 2020

Conversation

nik9000
Copy link
Member

@nik9000 nik9000 commented Mar 17, 2020

Hacking Elasticsearch with Eclipse is fairly broken. Some things work,
but we can't in good concience point contributors to Eclipse. This drops
the instrucions for Eclipse from CONTRIBUTING.md. We do want to fix
Eclipse. But we don't see that happening in the next few months. Once we
have fixed Eclipse we'll rewrite the instructions.

Relates #53664

Hacking Elasticsearch with Eclipse is fairly broken. Some things work,
but we can't in good concience point contributors to Eclipse. This drops
the instrucions for Eclipse from CONTRIBUTING.md. We *do* want to fix
Eclipse. But we don't see that happening in the next few months. Once we
*have* fixed Eclipse we'll rewrite the instructions.

Relates elastic#53664
@nik9000 nik9000 added the :Delivery/Build Build or test infrastructure label Mar 17, 2020
@nik9000 nik9000 requested a review from mark-vieira March 17, 2020 14:30
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (:Core/Infra/Build)

Copy link
Contributor

@mark-vieira mark-vieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nik9000 nik9000 merged commit 7a2d2ce into elastic:master Mar 17, 2020
@nik9000
Copy link
Member Author

nik9000 commented Mar 17, 2020

Thanks @mark-vieira !

@nik9000
Copy link
Member Author

nik9000 commented Mar 19, 2020

Hey! This is my thousandth pull request to elasticsearch!

@mark-vieira mark-vieira added the Team:Delivery Meta label for Delivery team label Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Delivery/Build Build or test infrastructure >non-issue Team:Delivery Meta label for Delivery team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants