Add new instruction for Eclipse #54894
Conversation
These work *much* better.
nik9000
added
>docs
|
Pinging @elastic/es-docs (>docs) |
|
Pinging @elastic/es-core-infra (:Core/Infra/Build) |
There was a problem hiding this comment.
Thanks, great setting-up tutorial. I left a few comments where I can imagine ppl might have questions for discussion.
I also had an issue initially importing the blank "Existing Gradle Project", got weird "Could not run phased build action using Gradle distribution ‘https://services.gradle.org/distributions/gradle-6.3-all.zip’.”" errors that I couldn't immediately action upon. The Eclipse log later pointed to a wrong java version (12) used for out build that was apparently picked up because I still run my Eclipse with Java 12. I manually set the "Java Home" gradle uses under Preferences>Gradle>Advanced Options. Maybe you can also do that in the import dialogue, I didn't check. Its probably worth either mentioning that in some sort of FAQ or point out that Eclipse should be run with at least Java 13?
|
|
||
| - Select **Window > Preferences** | ||
| - Select **Java > Compiler > Building** | ||
| - Set **Circular dependencies** to **Warning** |
There was a problem hiding this comment.
Maybe mention the setting is under "Build Path Problems". I know where they are because I had to set them so often but new users might need that extra bit of info.
| - Select **Window > Preferences** | ||
| - Select **Java > Compiler > Building** | ||
| - Set **Circular dependencies** to **Warning** | ||
| - Apply that and let the build spin away for a while |
There was a problem hiding this comment.
Had to do the Refresh/Cleanup dance once but I guess that's what everybody expects?
There was a problem hiding this comment.
I think accepting this change will prompt you to let it rebuild. I didn't do it when writing the instructions but it is what I remember. If you need to refresh or clean up we should so. I mostly don't have to do that though.
CONTRIBUTING.md
Outdated
| org | ||
| java | ||
| javax | ||
| static * |
There was a problem hiding this comment.
I wasn't exactly sure what this mean. I chose "New Staic" with a "*" pattern. Maybe worth elaborating?
|
@cbuescher, could you have another look? |
|
@elasticmachine update branch |
buildSrc/elastic.importorder
Outdated
| @@ -0,0 +1,8 @@ | |||
| #Organize Import Order | |||
There was a problem hiding this comment.
I assume this is an eclipse generated file. Maybe it would make sense to mention this in this file somewhere to know what its used for?
|
@nik9000 thanks for the updates, I like the setup guide a lot so far. One thing I'm still thinking about with regards to my previous comment in #54894 (review) is whether it would make sense to include a word or two about required jvm version to run gradle (and what to expect if you have a lower version). Maybe you have some ideas about that? |
| - Select **Existing Gradle Project** | ||
| - Select **Next** then **Next** again | ||
| - Set the **Project root directory** to the root of your elasticsearch clone | ||
| - Click **Finish** |
There was a problem hiding this comment.
For me an immediate finish did not produce the projects, I had to go through all Next stages and click the final Finish.
|
run elasticsearch-ci/bwc |
|
run elasticsearch-ci/default-distro |
These work much better.