This repository was archived by the owner on Mar 4, 2020. It is now read-only.
fix: do not crash when using a closed fs event watcher #70
+70
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@codebytere hey, you might want to look at microsoft/vscode#70566 (comment) where a user in VSCode sees that crash in the picture. Could it be that checking for |
|
Ah ok, looks like this came in as a backport. Maybe Electron should follow up and check if a more recent patch is available that avoids this issue. |
|
I am actually clueless how the crash in microsoft/vscode#70566 (comment) can happen. Looking at the code it seems like
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves electron/electron#14844.
This PR backports nodejs/node#20985 to
3-0-x.The original fix went out in
v10.5.0, so we don't need to backport it anywhere else since we'll cut4-0-xwith at least Nodev10.10.0./cc @pfrazee