Skip to content

Fix draft share sheet #2364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 11, 2020
Merged

Fix draft share sheet #2364

merged 4 commits into from
Nov 11, 2020

Conversation

Dominaezzz
Copy link
Contributor

@Dominaezzz Dominaezzz commented Nov 8, 2020 •
edited by t3chguy
Loading

Pull Request Checklist

  • Changes has been tested on an Android device or Android emulator with API 21
  • UI change has been tested on both light and dark themes
  • Pull request is based on the develop branch
  • Pull request updates CHANGES.md
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off

Fixes #2287

@Dominaezzz
Fix misleading identifier
62ca9a2 
Signed-off-by: Dominic Fischer <[email protected]>
@Dominaezzz
Fix draft bug
dee6f35 
Signed-off-by: Dominic Fischer <[email protected]>
@ganfra
Copy link
Member

ganfra commented Nov 9, 2020

Good catch, thanks! Could you please add a line the CHANGES.md file with the corresponding issue (#2287)

@t3chguy t3chguy requested a review from ganfra November 10, 2020 11:34
bmarty
bmarty approved these changes Nov 11, 2020
View reviewed changes
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update!

@bmarty bmarty merged commit 812b1f7 into element-hq:develop Nov 11, 2020
@Dominaezzz Dominaezzz deleted the fix_draft_sharesheet branch November 11, 2020 12:56
@T-bond T-bond mentioned this pull request Nov 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmarty bmarty bmarty approved these changes

@ganfra ganfra Awaiting requested review from ganfra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Input field doesn't clear after send, if text came from another app
4 participants
@Dominaezzz @ganfra @bmarty @t3chguy