A Couple Fixes, Tweaks and a Feature #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Tabs were used to layout the hilink stuff, now it's just spaces * A bit of trailing whitespace was removed in various areas
* I also HiLink'd jsonQuote back to Quote for backwards compatibility. I think it's better practice to match to a language specific highlight group, then link that back to a major group as it affords colorscheme designers more control.
This gives a specific highlight group to `:` and `,` characters.
elzr
added a commit
that referenced
this pull request
Aug 27, 2013
Fixed whitespace incosistencies, jsonQuote matchgroup renaming, and new jsonNoise grouping
|
Thanks for the tweaks @amadeus! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple things in this pull request:
Quotematchgroup tojsonQuote, thenHiLink'd that back toQuote. This provides colorscheme maintainers a finer level of granularity with their themes if they so prefer.jsonNoisegroup that targets:and,, and mapped it backNoise