Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do concealing in syntax file only if enabled. #41

Merged
merged 1 commit into from
Dec 17, 2014

Conversation

kristijanhusak
Copy link

I installed indentLine plugin, and got issues like mentioned in issue #23.

Since setting

let g:vim_json_syntax_conceal = 0 and
let g:indentLine_noConcealCursor="" or let g:indentLine_noConcealCursor="nc"

didn't work out properly, i noticed that when conceal is disabled manually (set to 0), syntax file still does concealing. Only the conceal cursor and level are not handled in that case. IndentLine sets conceallevel to 2, which automatically enables it for json, and i believe when someone disables the concealing manually expects not to have any of those functionality enabled, even when concealcursor/conceallevel is changed.

This is fixing the problem. I'm just not sure if it's good practice to use variables in syntax files.

elzr added a commit that referenced this pull request Dec 17, 2014
Do concealing in syntax file only if enabled via g:vim_json_syntax_conceal
@elzr elzr merged commit 054e560 into elzr:master Dec 17, 2014
@elzr
Copy link
Owner

elzr commented Dec 17, 2014

Thanks for noticing & fixing this edge case @kristijanhusak! I liked your solution and it seems acceptable practice to me :)

@kristijanhusak
Copy link
Author

;) Great! Thanks for merging! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants