Send changes immediately instead of queueing them #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For incremental change mode, all the changes in a `textDocument/didChange` message are interpreted as applying to the same version of a particular document. But each emacs change corresponds to the state of the document when the change happens. So harmonise the expectations by sending each change in its own message. closes emacs-lsp#112
|
Text changes strike again, argh. I'll have to see how much of an impact does this have on performance, sending a message to the language server on every change to the buffer might slow up emacs considerably :/ |
|
It should be possible to come up with a function that can go over a list of changes and re-align them to the original state, as expected by LSP. But it would have to be tested pretty comprehensively. And I am not sure that my elisp is up to it. |
|
However, without this patch the incremental state in the server is guaranteed to be wrong. |
|
Yeah, that's a big problem. I'll merge this for now, but we need to find a way to coalesce changes to a buffer. |
renatofdds
pushed a commit
to renatofdds/lsp-mode
that referenced
this pull request
May 13, 2023
…ring Fix docstring for lsp-java-progress-string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For incremental change mode, all the changes in a
textDocument/didChangemessage are interpreted as applying to the same version of a particular
document.
But each emacs change corresponds to the state of the document when the change
happens. So harmonise the expectations by sending each change in its own
message.
closes #112