-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove required keys, to support IAM roles #39
Remove required keys, to support IAM roles #39
Conversation
Similarly, I'd like to be able to specify a profile I have saved with the AWS CLI in lieu of the credentials. |
thanks @kkumler ! just one tiny thing, maybe clarify in the readme that the secret is to be used in combo with the access key and not with the IAM role? I know it seems obvious but it's probably better to be explicit just in case. @tomdale shall we do what you suggest as part of a separate PR? (I assume |
@ghedamat Sure, I'll update the readme a bit more for that. I'll keep this PR to just this change, but I could refactor things a bit and include functionality for all authentication options more cleanly, in a separate PR. |
@kkumler sounds like a plan! |
@ghedamat It looks like the AWS SDK respects the |
Yep. I was thinking that would cover most everyone's use case. It'll be Kris |
…ow for using IAM EC2 instance profiles.
ea7d0dd
to
1625565
Compare
👍 looks good! |
thanks @kkumler ! |
Remove required keys, to support IAM roles
Not specifying the access key id and secret access key to allow aws-sdk to load from the EC2 instance profile.
Fixes #29