Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove required keys, to support IAM roles #39

Merged

Conversation

kkumler
Copy link
Contributor

@kkumler kkumler commented Dec 11, 2015

Not specifying the access key id and secret access key to allow aws-sdk to load from the EC2 instance profile.
Fixes #29

@tomdale
Copy link

tomdale commented Dec 11, 2015

Similarly, I'd like to be able to specify a profile I have saved with the AWS CLI in lieu of the credentials.

@ghedamat
Copy link
Contributor

thanks @kkumler !

just one tiny thing, maybe clarify in the readme that the secret is to be used in combo with the access key and not with the IAM role? I know it seems obvious but it's probably better to be explicit just in case.

@tomdale shall we do what you suggest as part of a separate PR? (I assume aws-sdk will allow us to support your use case)

@kkumler
Copy link
Contributor Author

kkumler commented Dec 12, 2015

@ghedamat Sure, I'll update the readme a bit more for that.

I'll keep this PR to just this change, but I could refactor things a bit and include functionality for all authentication options more cleanly, in a separate PR.

@ghedamat
Copy link
Contributor

@kkumler sounds like a plan!

@tomdale
Copy link

tomdale commented Dec 12, 2015

@ghedamat It looks like the AWS SDK respects the AWS_PROFILE environment variable, so long as ember-cli-deploy-s3 isn't manually overriding anything: http://docs.aws.amazon.com/AWSJavaScriptSDK/guide/node-configuring.html#Using_Profiles_with_the_SDK

@kkumler
Copy link
Contributor Author

kkumler commented Dec 12, 2015

Yep. I was thinking that would cover most everyone's use case. It'll be
part of the readme update here.

Kris

@ghedamat ghedamat mentioned this pull request Dec 13, 2015
@kkumler kkumler force-pushed the feature/allow_iam_profiles branch from ea7d0dd to 1625565 Compare December 14, 2015 20:55
@lukemelia
Copy link
Contributor

👍 looks good!

@ghedamat
Copy link
Contributor

thanks @kkumler !

ghedamat added a commit that referenced this pull request Dec 15, 2015
Remove required keys, to support IAM roles
@ghedamat ghedamat merged commit 8710952 into ember-cli-deploy:master Dec 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants