Update minimum S3 permissions #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks @jeffreybiles LGTM, but will defer to @achambers for final confirmation |
|
LGTM.....Although, @ghedamat, this one should have a commit beginning with |
|
Indeed |
|
Thanks @jeffreybiles. Could you please just add |
When I used the old minimum S3 permissions, I got an error: `Statement is missing required element - Statement "Stmt1EmberCLIS3DeployPolicy" is missing "Principal" element. This PR adds in the Principal element, based on [this documentation](http://docs.aws.amazon.com/IAM/latest/UserGuide/reference_policies_elements.html#Principal)
|
@achambers Updated! Thanks for being patient through the delay. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I used the old minimum S3 permissions, I got an error: `Statement is missing required element - Statement "Stmt1EmberCLIS3DeployPolicy" is missing "Principal" element.
This PR adds in the Principal element, based on this documentation