-
-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade ember-test-helpers and node #1077
Conversation
I'd like to merge these PRs first https://github.com/emberjs/ember-qunit/pulls/@me |
This link might work better for people who aren't you 😅 https://github.com/emberjs/ember-qunit/pulls/NullVoxPopuli Unless I'm mistaken this will be blocked until Node 14 support is dropped |
Whoops, thanks! |
Right, so, my plan is to do two releases:
This is BECAUSE of all the issues we faced with |
looks like |
@@ -83,12 +83,12 @@ | |||
"webpack": "^5.75.0" | |||
}, | |||
"peerDependencies": { | |||
"@ember/test-helpers": "^2.9.3", | |||
"ember-source": ">=3.28", | |||
"@ember/test-helpers": ">=3.0.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just making notes for release,
we're dropping support for:
- @ember/test-helpers < 3.0.3
- ember-source < 4
- node < 16
this.element
-- folks should usequnit.dom
or[data-test-whatever]
andfind
this.render
--await render
is easy find and replace
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for this.render
, folks would need to remember to async function (assert)
+ await render
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, something to call out in the changelog
If merged, this PR updates ember-test-helpers to 3.0.2 (including peer dep declaration).
Details:
ember-lts-3.28
from ember-try scenarioaddon-test-support/adapter.js
@ember/string
v3.1.1@ember/test-helpers
to v3.0.3ember-source
to>=4.0.0
types/tests.ts
types/tests.ts
to use async/await instead of RenderingTestContext (deprecated)