Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make --enable-big-digits=30 the default #20

Closed
brettcannon opened this issue Nov 30, 2021 · 6 comments
Closed

Make --enable-big-digits=30 the default #20

brettcannon opened this issue Nov 30, 2021 · 6 comments

Comments

@brettcannon
Copy link
Collaborator

Any reason to not make this be automatic when wasm32 is set?
@emmatyping
Copy link
Owner

Yeah this would be a good thing to upstream to CPython.

@emmatyping
Copy link
Owner

We should also probably make --without-pymalloc and --with-ensurepip=no the default on WASM, I don't see either of those ever getting used.

@brettcannon
Copy link
Collaborator Author

Created #22 and #23 for --without-pymalloc and --with-ensurepip, respectively.

@tiran
Copy link
Collaborator

tiran commented Nov 30, 2021

Before we hard-code --enable-big-digits=30 and --without-pymalloc in configure and include, I would first like to understand and document the reason for the settings.

--without-ensurepip is obvious for emscripten, though.

@brettcannon
Copy link
Collaborator Author

The explanation for that setting is given at https://github.com/pyodide/pyodide/blob/771693ff99c55f5292823d86a95702291cf08755/cpython/Makefile#L129-L135

@tiran
Copy link
Collaborator

tiran commented Dec 2, 2021

Thanks, I missed the comment there.

Fixed in python/cpython#29887

@tiran tiran closed this as completed Dec 2, 2021
tiran added a commit to tiran/python-wasm that referenced this issue Dec 2, 2021
@tiran
Remove unnecessary configure options
e757326 
* ``--enable-big-digits=30`` is now default for wasm platforms, see emmatyping#20
* ``--with-ensurepip=no`` is now default for emscripten platform, see emmatyping#23
* ``--disable-ipv6`` was never necessary, we have
  ``ac_cv_buggy_getaddrinfo=no``
@tiran tiran mentioned this issue Dec 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@brettcannon @tiran @emmatyping