Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmake toolchain hardcodes sizeof void pointer to 32-bit #20175

Closed
jspanchu opened this issue Aug 31, 2023 · 0 comments · Fixed by #20201
Closed

cmake toolchain hardcodes sizeof void pointer to 32-bit #20175

jspanchu opened this issue Aug 31, 2023 · 0 comments · Fixed by #20201

Comments

@jspanchu
Copy link
Contributor

While experimenting with cross compilation of a C++ project to webassembly using 64-bit memory (-sMEMORY64=1), I noticed that emcmake has no regard for -sMEMORY64 setting and hard codes CMAKE_SIZEOF_VOIDP to 4 bytes. This causes a problem for a lot of code which looks at that cmake variable to enable/disable 64-bit code paths.
sbc100 added a commit that referenced this issue Sep 7, 2023
@sbc100
[wasm64] Fix pointer size detection
9e6ff07 
Fixes: #20175
@sbc100 sbc100 mentioned this issue Sep 7, 2023
Merged
sbc100 added a commit that referenced this issue Sep 7, 2023
@sbc100
[wasm64] Fix pointer size detection
743c26c 
Fixes: #20175
sbc100 added a commit that referenced this issue Sep 7, 2023
@sbc100
[wasm64] Fix pointer size detection (#20201)
30c96f6 
Fixes: #20175
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[wasm64] Fix pointer size detection emscripten-core/emscripten
1 participant
@jspanchu