-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't pass -fno-inline-functions
when -Oz
/-Os
are used
#17843
Conversation
This does seem like the right thing to me. However reading the code size changes my impression is the opposite of yours - seems to be more regressions than wins, and some seem significant (e.g. |
Adding back |
bce4a33
to
653a2c6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, lgtm.
If one of us has time eventually it might be interesting to look into the system lib flags and check if they are optimal. But seems low priority to me.
We have no reason not to let clang use its own heuristics here. As a followup we can consider completely removing the `INLINGING_LIMIT` setting since it no longer serves any purpose other than to set this clang flag. This change comes with come code size wins and some losses due to the fact that some system libraries are compiled with `-Os` or `-Oz`. The interesting changes seem to mostly be wins.
653a2c6
to
8a5c2ca
Compare
We have no reason not to let clang use its own heuristics here.
As a followup we can consider completely removing the
INLINGING_LIMIT
setting since it no longer serves any purpose other than to set this clang flag.