Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove compat/sys/sysctl.h header #18863

Merged
merged 1 commit into from
Feb 27, 2023
Merged

Remove compat/sys/sysctl.h header #18863

merged 1 commit into from
Feb 27, 2023

Conversation

sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Feb 27, 2023

We don't implement sysctl itself so there seem little point in keeping this header around.

See #18858

@sbc100 sbc100 requested a review from kripken February 27, 2023 20:05
Copy link
Member

@kripken kripken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like in the past we documented this in the changelog, e.g. for aio.h we have this:

- aio.h was removed from the sysroot.  Emscripten doesn't support any of the
  functions in this header.

We don't implement sysctl itself so there seem little point in
keeping this header around.

See #18858
@sbc100 sbc100 force-pushed the remove_sysctl_header branch from 3fc4616 to 83a5521 Compare February 27, 2023 21:08
@sbc100 sbc100 merged commit 15f7632 into main Feb 27, 2023
@sbc100 sbc100 deleted the remove_sysctl_header branch February 27, 2023 22:53
impact-maker pushed a commit to impact-maker/emscripten that referenced this pull request Mar 17, 2023
We don't implement sysctl itself so there seem little point in
keeping this header around.

See emscripten-core#18858
impact-maker pushed a commit to impact-maker/emscripten that referenced this pull request Mar 17, 2023
We don't implement sysctl itself so there seem little point in
keeping this header around.

See emscripten-core#18858
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants