Add support for ipaddress objects in JSONEncoder #9087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corenting
force-pushed
the
jsonencoder_ipaddress
branch
from
277e04a to
ef0ad04
Compare
|
@auvipy sorry for the ping, is it possible to take a look? |
|
Yes of course |
Merged
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
corenting
force-pushed
the
jsonencoder_ipaddress
branch
from
ef0ad04 to
afdcf5c
Compare
tfranzel
approved these changes
Feb 27, 2025
There was a problem hiding this comment.
I believe this should be very safe to add and has afais no potential for a regression.
ipaddress was added in python 3.3, and thus should be safe to import too.
I think this is a good change because it closes a functional gap, that one would consider to not even be there, until it bites you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The aim of this PR is to have support for ipaddress objects in JSONEncoder, similar to what was done for UUIDs for example.