Remove discontinued channel apps from customApps.js #904
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylanmccall
force-pushed
the
prune-custom-apps
branch
from
f0df665 to
9e5909d
Compare
manuq
approved these changes
Dec 19, 2023
| @@ -141,7 +137,6 @@ export const EkIguanaSections = [ | |||
| { | |||
| name: 'Literature and Language Arts', | |||
| channels: [ | |||
| '59bb2e5a3d2e5e3b85b87d9ab4daa2f3', // reading | |||
There was a problem hiding this comment.
Removing channels from EkIguanaSections means nothing to current Endless Key. EkIguanaSections was for the hardcoded order of channels in the landing page of the USB option (which still has the channels in the USB stick). A real cleanup would be to remove EkIguanaSections altogether with the corresponding views/components:
- kolibri_explore_plugin/assets/src/components/EkIguanaList.vue
- kolibri_explore_plugin/assets/src/views/DiscoveryPageEkIguana.vue
This app was removed in 40b02b3, but it was still referenced in customApps.js. Custom thumbnails and icons for this channel remain in the repository, so they are not changed here. https://phabricator.endlessm.com/T35147
dylanmccall
force-pushed
the
prune-custom-apps
branch
from
9e5909d to
7e90a88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The source files for several channel apps were removed in 40b02b3, but these were still referenced in customApps.js.
Custom thumbnails and icons for these channels are still in the repository, so they are not changed here.
https://phabricator.endlessm.com/T35147