Skip to content

edit: EVM-chain reverse resolution #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

TateB
Copy link
Collaborator

@TateB TateB commented Nov 21, 2024

No description provided.

Copy link

cloudflare-workers-and-pages bot commented Nov 21, 2024

Deploying ensips with  Cloudflare Pages  Cloudflare Pages

Latest commit: f4ed924
Status: ✅  Deploy successful!
Preview URL: https://e6650744.ensips.pages.dev
Branch Preview URL: https://edits-evm-chain-reverse-reso.ensips.pages.dev

View logs

@TateB TateB requested review from adraffy and Arachnid March 11, 2025 08:55
ensips/19.md Outdated
* Reverse registrars will be setup on each EVM-chain, with a corresponding registry
* Reverse registrar will only allow setting the name and text record without resolver customisability.
- Reverse Registrars will be setup on each EVM-chain, with combined registry/registrar/resolver functionality.
- Registrars will only allow setting the name, without resolver customisability.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Registrars will only allow setting the name, without resolver customisability.
- Reverse resolvers will only allow setting the name, without resolver customisability.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you mean it should be "Reverse registrars" rather than "Registrars"? otherwise the change makes the terminology inconsistent

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough. In that case it should make it clear that reverse registrars set their own custom resolver, which only allows the name to be set.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i might need to reword some of this. "Reverse registrar" = L2 contract that maintains the registrar capability, "Reverse resolver" = L1 contract that resolves to the L2 registrar values.

Copy link
Member

@adraffy adraffy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

funny, I just talked to Nick about this ENSIP. I think your changes to the steps are good (rather than using the UR's perspective.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants