Skip to content

sentry don't capture response #917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

nichtsam
Copy link
Contributor

@nichtsam nichtsam commented Feb 3, 2025

I got this from sentry:

Error: Object captured as exception with keys: data, internal, status, statusText

Test Plan

Checklist

  • Tests updated
  • Docs updated

Screenshots

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution. Can you verify that we are still getting Sentry errors from the server when we hit a 404 or a 500?

@kentcdodds kentcdodds merged commit a3a050e into epicweb-dev:main Feb 3, 2025
4 checks passed
@nichtsam
Copy link
Contributor Author

nichtsam commented Feb 3, 2025

Thanks for this contribution. Can you verify that we are still getting Sentry errors from the server when we hit a 404 or a 500?

Thanks for reviewing! I tested it, and I believe we won’t get Sentry errors for 404s since they’re thrown manually, which I considered handled. However, 500 errors should still be captured by Sentry since they’re actual errors. Essentially, throw new Response() won’t be captured, but throw new Error() will.

@kentcdodds
Copy link
Member

Ok, I think 400s probably shouldn't be reported anyway so we're probably fine. Thanks!

@nichtsam nichtsam deleted the pr/error-boundary-no-capture-response branch February 9, 2025 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants