Refactor CI auditing #1046
Merged
Refactor CI auditing #1046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This changes how we audit (for vulns and deprecations) in CI from a reusable workflow to two self-contained workflows. I believe this makes the setup a bit more explicit (when each happens) at the cost of some duplication (which is counteracted by the removal of conditional logic) and potential audit failures if there are build failures (because there is no longer a `needs:` relation between the build job and audit jobs, tho at the same time only one of the audit jobs should actually be blocked by the build job).
ericcornelissen
force-pushed
the
refactor-ci-audit
branch
from
3c890f3 to
7539d41
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This changes how we audit (for vulns and deprecations) in CI from a reusable workflow to two self-contained workflows. I believe this makes the setup a bit more explicit, and thus (hopefully) easier to understand.