Set up continuous SAST with Semgrep #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a Static Application Security Test (SAST) scan with Semgrep [1]. Semgrep supports scanning JavaScript, Dockerfiles, and configuration files such as GitHub Actions workflows. Harden-runner is not configured for this job because it doesn't work with container-based jobs. -- 1. https://semgrep.dev
ericcornelissen
added
ci
ericcornelissen
force-pushed
the
sast-semgrep
branch
2 times, most recently
from
7c7bbc7 to
5c49336
Compare
Prevent shell injection in this workflow by capturing the update type as an environment variable and using the environment variable. This way, the expansion of the input in the command can't result in shell injection. Yes, this particular case is not very vulnerable due to 1) limited value space, and 2) trusted triggers. However, it's hard to guarantee those variables stay fixed and simple to apply the fix. This problem was detected by Semgrep (https://semgrep.dev) using a full- repository scan.
ericcornelissen
force-pushed
the
sast-semgrep
branch
from
5c49336 to
6f93b55
Compare
This was referenced Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add a SAST scan with Semgrep.