Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle OpenSSL 3.x with packages for older systems #4511

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

jacekwegr
Copy link
Collaborator

@jacekwegr jacekwegr commented Mar 25, 2025

This PR adds a bundled OpenSSL 3.x for systems where it is not available in official repositories. The bundled version is used only if no system-wide OpenSSL 3.x installation is detected at runtime. This provides a middle ground between requiring users to install OpenSSL 3.x themselves and risking conflicts with existing installations.

If you're looking for the source of the OpenSSL 3.x integration, please see this related PR: esl/cimg-erlang#11

Successful package build workflow: https://app.circleci.com/pipelines/github/esl/MongooseIM/13926/workflows/5fdea30a-bacf-4e27-9147-06b6ff33be27

@mongoose-im

This comment was marked as outdated.

Copy link

codecov bot commented Mar 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.55%. Comparing base (4ef2739) to head (7345acf).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4511      +/-   ##
==========================================
- Coverage   85.58%   85.55%   -0.03%     
==========================================
  Files         559      559              
  Lines       34065    34065              
==========================================
- Hits        29154    29146       -8     
- Misses       4911     4919       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jacekwegr jacekwegr force-pushed the bundle-openssl-for-older-systems branch from abc56c9 to f8751d0 Compare March 27, 2025 11:46
@jacekwegr jacekwegr force-pushed the bundle-openssl-for-older-systems branch from f8751d0 to 1e87ce8 Compare March 27, 2025 11:55
@mongoose-im

This comment was marked as outdated.

@jacekwegr jacekwegr force-pushed the bundle-openssl-for-older-systems branch from bb3cc7c to 48c4bf9 Compare March 27, 2025 12:09
@mongoose-im

This comment was marked as outdated.

@jacekwegr jacekwegr force-pushed the bundle-openssl-for-older-systems branch from 48c4bf9 to fb1395c Compare March 27, 2025 12:20
@mongoose-im

This comment was marked as outdated.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Mar 28, 2025

elasticsearch_and_cassandra_27 / elasticsearch_and_cassandra_mnesia / 7345acf
Reports root/ big
OK: 683 / Failed: 0 / User-skipped: 72 / Auto-skipped: 0


small_tests_27 / small_tests / 7345acf
Reports root / small


small_tests_26 / small_tests / 7345acf
Reports root / small


small_tests_27_arm64 / small_tests / 7345acf
Reports root / small


ldap_mnesia_26 / ldap_mnesia / 7345acf
Reports root/ big
OK: 2373 / Failed: 0 / User-skipped: 1088 / Auto-skipped: 0


dynamic_domains_mysql_redis_27 / mysql_redis / 7345acf
Reports root/ big
OK: 4907 / Failed: 0 / User-skipped: 181 / Auto-skipped: 0


ldap_mnesia_27 / ldap_mnesia / 7345acf
Reports root/ big
OK: 2373 / Failed: 0 / User-skipped: 1088 / Auto-skipped: 0


internal_mnesia_27 / internal_mnesia / 7345acf
Reports root/ big
OK: 2546 / Failed: 0 / User-skipped: 915 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_27 / pgsql_mnesia / 7345acf
Reports root/ big
OK: 4942 / Failed: 0 / User-skipped: 146 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / 7345acf
Reports root/ big
OK: 4942 / Failed: 0 / User-skipped: 146 / Auto-skipped: 0


pgsql_cets_27 / pgsql_cets / 7345acf
Reports root/ big
OK: 5031 / Failed: 0 / User-skipped: 215 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_27 / odbc_mssql_mnesia / 7345acf
Reports root/ big
OK: 4937 / Failed: 0 / User-skipped: 151 / Auto-skipped: 0


mysql_redis_27 / mysql_redis / 7345acf
Reports root/ big
OK: 5313 / Failed: 0 / User-skipped: 176 / Auto-skipped: 0


pgsql_mnesia_27 / pgsql_mnesia / 7345acf
Reports root/ big
OK: 5333 / Failed: 1 / User-skipped: 155 / Auto-skipped: 0

graphql_server_SUITE:admin_cli:clustering_tests:join_successful
{error,{#{what => invalid_response_code,
      response_code => {exit_status,1},
      expected_type => ok},
    [{graphql_helper,assert_response_code,2,
             [{file,"/home/circleci/project/big_tests/tests/graphql_helper.erl"},
              {line,258}]},
     {graphql_helper,get_ok_value,2,
             [{file,"/home/circleci/project/big_tests/tests/graphql_helper.erl"},
              {line,241}]},
     {graphql_server_SUITE,join_successful,1,
                 [{file,"/home/circleci/project/big_tests/tests/graphql_server_SUITE.erl"},
                {line,153}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1794}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1303}]},
     {test_server,run_test_case_eval,9,
            [{file,"test_server.erl"},{line,1235}]}]}}

Report log


cockroachdb_cets_27 / cockroachdb_cets / 7345acf
Reports root/ big
OK: 5034 / Failed: 3 / User-skipped: 215 / Auto-skipped: 0

pubsub_SUITE:dag+last_item_cache:send_last_published_item_no_items_test
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,
          <<"alice_send_last_published_item_no_items_test_3181@localhost/res1">>,
          escalus_tcp,<0.110077.0>,
          [{event_manager,<0.110066.0>},
           {server,<<"localhost">>},
           {username,
             <<"alicE_send_last_published_item_no_items_test_3181">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.110066.0>},
            {server,<<"localhost">>},
            {username,
              <<"alicE_send_last_published_item_no_items_test_3181">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,
             <<"alice_send_last_published_item_no_items_test_3181">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,
             <<"alicE_send_last_published_item_no_items_test_3181">>},
           {server,<<"localhost">>},
           {password,<<"matygrysa">>},
           {stream_id,<<"24e45de50325ff7d">>}]},
        5000],
       [{file,
          "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {pubsub_tools,receive_response,3,
       [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
        {line,434}]},
     {pubsub_tools,receive_and_check...

Report log

pubsub_SUITE:dag+last_item_cache:send_last_published_item_no_items_test
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,
          <<"alice_send_last_published_item_no_items_test_3184@localhost/res1">>,
          escalus_tcp,<0.110152.0>,
          [{event_manager,<0.110142.0>},
           {server,<<"localhost">>},
           {username,
             <<"alicE_send_last_published_item_no_items_test_3184">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.110142.0>},
            {server,<<"localhost">>},
            {username,
              <<"alicE_send_last_published_item_no_items_test_3184">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,
             <<"alice_send_last_published_item_no_items_test_3184">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,
             <<"alicE_send_last_published_item_no_items_test_3184">>},
           {server,<<"localhost">>},
           {password,<<"matygrysa">>},
           {stream_id,<<"52e4ba7a0ad56daf">>}]},
        5000],
       [{file,
          "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {pubsub_tools,receive_response,3,
       [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
        {line,434}]},
     {pubsub_tools,receive_and_check...

Report log

sm_SUITE:ws_tests:ping_timeout
{error,{{badmatch,false},
    [{escalus_session,stream_resumption,2,
              [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_session.erl"},
               {line,259}]},
     {escalus_connection,connection_step,2,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
                {line,161}]},
     {lists,foldl_1,3,[{file,"lists.erl"},{line,2151}]},
     {escalus_connection,start,2,
               [{file,"/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"},
                {line,145}]},
     {sm_helper,connect_spec,3,
          [{file,"/home/circleci/project/big_tests/tests/sm_helper.erl"},
           {line,156}]},
     {sm_SUITE,ping_timeout,1,
           [{file,"/home/circleci/project/big_tests/tests/sm_SUITE.erl"},
          {line,901}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1794}]},
     {test_server,run_test_case_eval1,6,
            [{file,"test_server.erl"},{line,1303}]}]}}

Report log


mssql_mnesia_27 / odbc_mssql_mnesia / 7345acf
Reports root/ big
OK: 5329 / Failed: 0 / User-skipped: 160 / Auto-skipped: 0


cockroachdb_cets_27 / cockroachdb_cets / 7345acf
Reports root/ big
OK: 235 / Failed: 1 / User-skipped: 2 / Auto-skipped: 0

pubsub_SUITE:dag+last_item_cache:send_last_published_item_no_items_test
{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,
          <<"alice_send_last_published_item_no_items_test_71@localhost/res1">>,
          escalus_tcp,<0.2248.0>,
          [{event_manager,<0.2247.0>},
           {server,<<"localhost">>},
           {username,
             <<"alicE_send_last_published_item_no_items_test_71">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.2247.0>},
            {server,<<"localhost">>},
            {username,
              <<"alicE_send_last_published_item_no_items_test_71">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,
             <<"alice_send_last_published_item_no_items_test_71">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5222},
           {auth,{escalus_auth,auth_plain}},
           {wspath,undefined},
           {username,
             <<"alicE_send_last_published_item_no_items_test_71">>},
           {server,<<"localhost">>},
           {password,<<"matygrysa">>},
           {stream_id,<<"02fdb04cb818e3c8">>}]},
        5000],
       [{file,
          "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {pubsub_tools,receive_response,3,
       [{file,"/home/circleci/project/big_tests/tests/pubsub_tools.erl"},
        {line,434}]},
     {pubsub_tools,receive_and_check_response,4,
   ...

Report log

@jacekwegr jacekwegr marked this pull request as ready for review March 28, 2025 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants